Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add TextFilter #658
add TextFilter #658
Changes from 5 commits
5fc64b7
3d7b56a
b02c1eb
5450ee6
2d8ae7c
5f54504
c004b3a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if
pass_filter
is called without build? I guess imgui aborts?If so, I wonder if it'd be worth adding some extra object so you do
And since the
pass_filter
methods etc would be on thatTextFilterHandle
struct, it would be impossible to misuse (since you can't get at thepass_filter
method without calling one of those methods)Not a vital thing - there are plenty of ways to make imgui abort via the bindings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tried to run
pass_filter
withoutbuild
ordraw
intest_window_impl
. It doesn't crash, just does nothing, likeInputText
withoutbuild
. I just specify in the documentation that we have to call them before using the filter.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this method used for? It's not immediatly clear (..even looking at imgui.cpp!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't exactly know too.. I have to try it but I don't have time lately.