Update MSRV to 1.56 #660
Merged
Update MSRV to 1.56 #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The winit->x11-dl 2.22.0 dependency now requires the 2021 edition which forces us to at least Rust 1.56 (at least on Linux)
thomcc
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #658 - indirect dependency now requires 2021 edition, which forces us to 1.56
Noted in the changelog, and CI
We could probably workaround this in some way (and technically people can pin that dep back and it'll still work in 1.54).. but given we have minimal reason to be conservative with our MSRV (imgui-rs isn't a widely used low-level libray thing like serde or whatever), just bumping it to "lowest version which doesn't cause us trouble" is a good compromise