Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing im_str! marco #680

Merged
merged 1 commit into from Dec 2, 2022
Merged

Removing im_str! marco #680

merged 1 commit into from Dec 2, 2022

Conversation

dbr
Copy link
Contributor

@dbr dbr commented Nov 29, 2022

Closes #576

Kind of in two minds about removing this

In favour of removing it:

  • the macro is not necessary any more (im_str!("blah") can just replaced with "blah", and doing this replacement even in a large code base wasn't particularly ardious)
  • it's been deprecated since v0.8 which has been out about a year, so chances are most projects that might update to v0.9 would have already removed it to silence the annoying deprecation-warning

In favour of keeping it:

  • The macro is relatively self-contained and not much burdent to keep around
  • Nostalgia? ( 馃槢 )

@dbr dbr merged commit 645d7eb into imgui-rs:main Dec 2, 2022
@dbr dbr deleted the rmimstr branch December 2, 2022 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove deprecated im_str
1 participant
@dbr