Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to imgui 1.89 #685

Closed
wants to merge 3 commits into from
Closed

Update to imgui 1.89 #685

wants to merge 3 commits into from

Conversation

dbr
Copy link
Contributor

@dbr dbr commented Dec 2, 2022

More straight forward than I had expected as the major changes are all backwards compatible

Few things to do:

  1. Fix up docking feature
  2. The 1.89.1 tag still had IMGUI_VERSION containing 1.89.1 WIP - update in the next commit. Should probably use this instead of the exact tagged release to avoid the version string being confusing
  3. Consider backwards-compatbility for the ImageButton change
  4. Investigate what changes need to take advantage of the event-based input stuff (probably a separate PR)
  5. Check over changelog for versions since previous 1.86 to see if there's any other significant changes for the bindings

- No longer has separate frame-padding (uses style var)
- Requires ID label
Key variants no longer start at 0 and increment with new IO event refactoring (ID's start at 500, with 0 being "None")
@dbr
Copy link
Contributor Author

dbr commented Dec 21, 2022

Superseded by #688 🥳

@dbr dbr closed this Dec 21, 2022
@dbr dbr deleted the imgui189 branch January 11, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant