修复当开启 Redis 序列化时，geoAdd() 会报错：ERR value is not a valid float #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phpredis 官方认为这不算 BUG：phpredis/phpredis#1549
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## 2.1 #579 +/- ##
============================================
+ Coverage 64.10% 65.45% +1.34%
- Complexity 11222 11223 +1
============================================
Files 891 891
Lines 30565 30571 +6
============================================
+ Hits 19594 20010 +416
+ Misses 10971 10561 -410
☔ View full report in Codecov by Sentry. |
NHZEX
pushed a commit
to NHZEX/imi
that referenced
this pull request
Oct 18, 2023
) * 修复当开启 Redis 序列化时，geoAdd() 会报错：ERR value is not a valid float phpredis 官方认为这不算 BUG：phpredis/phpredis#1549 * 在 Windows 上不测试 geoadd，因为 windows 版 redis 版本太低不支持 geo * 更新文档
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #578
这是 phpredis 扩展的一个陈年老bug，当启用 Redis 序列化时候，
geoAdd()的经纬度参数值会被序列化后传输。官方认为这不算 BUG，所以这里做了一个兼容处理。
前人提问记录：phpredis/phpredis#1549。