verified test case and fixed logging

issue #217

imixs-workflow-core/src/main/java/org/imixs/workflow/bpmn/BPMNModelHandler.java

@@ -423,8 +423,9 @@ public BPMNModel buildModel() throws ModelException {
 
 	/**
 	 * This method returns all SourceTask Elements connected to a given eventID.
-	 * The method takes care about loop events and follow up events (later ones
-	 * will be handled by the method addImixsEvent().
+	 * The method takes care about loop events and follow up events. Later ones
+	 * are handled by the method addImixsEvent(). For that reason, the
+	 * result of this method can be also an empty list.
 	 * 
 	 * An event can be a shared event so it is possible that more than one
 	 * source tasks are found
@@ -505,12 +506,9 @@ private List<ItemCollection> findSourceTasks(String eventID) throws ModelExcepti
 				}
 			}
 		}
-		if (result.size() == 0) {
-			logger.warning("Imixs BPMN Event '" + eventID + "' has no target task!");
-		}
 
+		logger.fine("Imixs BPMN Event '" + eventID + "' is directly assigend to " + result.size() + " task elements");
 		return result;
-
 	}
 
 	/**
@@ -538,7 +536,6 @@ private void addImixsEvent(String eventID, ItemCollection sourceTask) throws Mod
 					"Imixs BPMN Event '" + eventName + "' has no source task!");
 		}
 
-
 		List<SequenceFlow> outFlows = findOutgoingFlows(eventID);
 		if (outFlows == null || outFlows.size() == 0) {
 			// invalid model!!
@@ -902,7 +899,7 @@ public ItemCollection findImixsTargetTask(SequenceFlow flow) {
 			for (SequenceFlow aflow : refList) {
 				// recursive call....
 				ItemCollection aResult = findImixsTargetTask(aflow);
-				if (aResult!=null) {
+				if (aResult != null) {
 					// we got the task!
 					return aResult;
 				}

imixs-workflow-core/src/test/java/org/imixs/workflow/bpmn/TestBPMNParserStartEventFollowUp.java

@@ -4,6 +4,7 @@
 import java.io.InputStream;
 import java.io.UnsupportedEncodingException;
 import java.text.ParseException;
+import java.util.List;
 
 import javax.xml.parsers.ParserConfigurationException;
 
@@ -66,41 +67,38 @@ public void testSimple()
 		// test count of elements
 		Assert.assertEquals(1, model.findAllTasks().size());
 
-		// test task 1000
-		ItemCollection task = model.getTask(1000);
-		Assert.assertNotNull(task);
-		Assert.assertEquals("1.0.0", task.getItemValueString("$ModelVersion"));
-		Assert.assertEquals("Simple", task.getItemValueString("txtworkflowgroup"));
-
-		// test import activity for task 1000.20 (followup)
+		// test import activity for task 1000.20 (import)
 		ItemCollection activity = model.getEvent(1000, 20);
 		Assert.assertNotNull(activity);
 		Assert.assertEquals("import", activity.getItemValueString("txtname"));
-
-		Assert.assertEquals("1", activity.getItemValueString("keyFollowUp"));
+		Assert.assertTrue("1".equals(activity.getItemValueString("keyFollowUp")));
 		Assert.assertEquals(30, activity.getItemValueInteger("numNextActivityID"));
 		Assert.assertEquals(1000, activity.getItemValueInteger("numprocessid"));
 
-		// test 1000.30
+		// test 1000.30 ([followup])
 		activity = model.getEvent(1000, 30);
 		Assert.assertNotNull(activity);
 		Assert.assertEquals("[follow up]", activity.getItemValueString("txtname"));
-
 		Assert.assertFalse("1".equals(activity.getItemValueString("keyFollowUp")));
 		Assert.assertEquals(1000, activity.getItemValueInteger("numprocessID"));
 		Assert.assertEquals(1000, activity.getItemValueInteger("numprocessid"));
 
-		// test 1000.10
+		// test 1000.10 (save)
 		activity = model.getEvent(1000, 10);
 		Assert.assertNotNull(activity);
 		Assert.assertEquals("Save", activity.getItemValueString("txtname"));
-
 		Assert.assertFalse("1".equals(activity.getItemValueString("keyFollowUp")));
 		Assert.assertEquals(1000, activity.getItemValueInteger("numprocessID"));
 		Assert.assertEquals(1000, activity.getItemValueInteger("numprocessid"));
 
-	}
-
+		// Now we test the task 1000
+		ItemCollection task = model.getTask(1000);
+		Assert.assertNotNull(task);
+		Assert.assertEquals("1.0.0", task.getItemValueString("$ModelVersion"));
+		Assert.assertEquals("Simple", task.getItemValueString("txtworkflowgroup"));
+		List<ItemCollection> events = model.findAllEventsByTask(1000);
+		Assert.assertEquals(3, events.size());
 
+	}
 
 }

imixs-workflow-core/src/test/resources/bpmn/startevent_followup.bpmn

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!-- origin at X=0.0 Y=0.0 -->
-<bpmn2:definitions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:bpmn2="http://www.omg.org/spec/BPMN/20100524/MODEL" xmlns:bpmndi="http://www.omg.org/spec/BPMN/20100524/DI" xmlns:dc="http://www.omg.org/spec/DD/20100524/DC" xmlns:di="http://www.omg.org/spec/DD/20100524/DI" xmlns:ext="http://org.eclipse.bpmn2/ext" xmlns:imixs="http://www.imixs.org/bpmn2" xmlns:xs="http://www.w3.org/2001/XMLSchema" id="Definitions_1" exporter="org.eclipse.bpmn2.modeler.core" exporterVersion="1.3.0.Final-v20160602-2145-B47" targetNamespace="http://www.imixs.org/bpmn2">
+<bpmn2:definitions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:bpmn2="http://www.omg.org/spec/BPMN/20100524/MODEL" xmlns:bpmndi="http://www.omg.org/spec/BPMN/20100524/DI" xmlns:dc="http://www.omg.org/spec/DD/20100524/DC" xmlns:di="http://www.omg.org/spec/DD/20100524/DI" xmlns:ext="http://org.eclipse.bpmn2/ext" xmlns:imixs="http://www.imixs.org/bpmn2" xmlns:xs="http://www.w3.org/2001/XMLSchema" id="Definitions_1" exporter="org.eclipse.bpmn2.modeler.core" exporterVersion="1.3.1.Final-v20161006-1425-B58" targetNamespace="http://www.imixs.org/bpmn2">
   <bpmn2:extensionElements>
     <imixs:item name="txtworkflowmodelversion" type="xs:string">
       <imixs:value><![CDATA[1.0.0]]></imixs:value>