Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored to fix 3 implementation smells #855

Merged

Conversation

ashishbhasin45
Copy link

  1. Decompose complex conditional.
    Location- Sub-project: imixs-workflow-core
    Package: org.imixs.workflow.xml
    class: XMLItem
    Method: stripNonValidXMLCharacters

  2. Renamed the variable in the specified method from o to a currentReportItemValue for better understandability.
    Location- Sub-project: imixs-workflow-engine
    Package: org.imixs.workflow.engine
    Class: ReportService
    Method: updateReport

  3. Decomposed parseTag method to resolve a complex method code smell for readability and understandability.
    Location- Sub-project: imixs-workflow-core
    Package: org.imixs.workflow.util
    class: XMLParser
    Method: parseTag

Copy link
Member

@rsoika rsoika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!
Yes it was not the the best code ;-)
As we this part is covered by a lot of unit tests we can submit it. Please only add my method comment.

@rsoika rsoika merged commit dec3110 into imixs:master Apr 2, 2024
1 check passed
@rsoika rsoika added this to the 6.0.6 milestone Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants