Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: grab sha sooner or as argument #3

Closed
imjohnbo opened this issue May 26, 2020 · 0 comments · Fixed by #4
Closed

Bug: grab sha sooner or as argument #3

imjohnbo opened this issue May 26, 2020 · 0 comments · Fixed by #4

Comments

@imjohnbo
Copy link
Owner

The sha should be referenced sooner that this so that this scenario doesn't happen:

  • Time T: admin comments /ok-to-test
  • Time T + 1: malicious code introduced into PR branch
  • Time T + 2: PR branch checked out

Solution 1: accept sha argument like /ok-to-test 827asa
Solution 2: shorten time window by calculating the merge commit in ok-to-test.yml instead of integration.yml
imjohnbo added a commit that referenced this issue May 28, 2020
@imjohnbo
Update integration.yml
6d68abd 
Closes #3
@imjohnbo imjohnbo mentioned this issue May 28, 2020
Merged
@alldoami alldoami mentioned this issue Dec 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update integration.yml imjohnbo/ok-to-test
1 participant
@imjohnbo