-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ts 5.5 tsconfig.json with ${configDir} #133
Comments
Thank you for your feedback, @Q16solver :)
However, using a higher version of the TypeScript compiler doesn't seem to be a big problem. As a workaround, could you try using the overrides feature? |
Edit: nvm this doesn't work lol |
@Q16solver Hello, thank you for your patience
|
Edit: ctix still is unable to detect the files and builds empty index.js files, might be something to do with ts-morph |
@Q16solver Can you please provide a reproducible repo, or tell me what I need to do in the repo mentioned in the first issue. Thank you. |
@imjuni If you fork my repo https://github.com/Esposter/Esposter:
You should encounter the issue that dist files are empty. If you then change the tsconfig to be the non config dir one (you can reference main branch), then ctix generates fine Thanks for being willing to investigate! |
@Q16solver Hello, Due to my recent personal circumstances, it is difficult for me to analyse the problem at this code level. I looked at the repo you uploaded and saw that the I think the problem is that the tsconfig.json file in the shared project doesn't have the include and exclude options, so it can't find the project files to add to the |
@imjuni oh you're right! seems like doing **/*.ts in |
However, if neither the ctix I'll add a feature to tell about this in the next version to make it more obvious, thanks. |
Yeah, though it seems like if the |
Hello! Recently, ts 5.5 was announced in beta with new feature https://devblogs.microsoft.com/typescript/announcing-typescript-5-5-beta/#the-configdir-template-variable-for-configuration-files
This lets us share tsconfig across packages, and I wanted to use it for my monorepo, but ctix cannot find the files properly, my guess is that it's still using an older version of typescript, I'm not sure if it's this package? or from the ts-morph package where it wraps the ts compiler API, I can think of perhaps 2 ways to solve it here:
Have a "next" branch that ups the deps to the beta version as well and simply just publish it as an alpha/beta
Have the typescript dep as a peerDep? and have userland install the required version? I'm not sure if that actually works, just a thought
For reference I used with typescript ver: "5.5.0-dev.20240518",
and shared configuration package I'm trying to create: https://github.com/Esposter/Esposter/tree/shared-configuration/packages/configuration
usage: https://github.com/Esposter/Esposter/blob/shared-configuration/packages/shared/package.json
The text was updated successfully, but these errors were encountered: