Adding proper safety checks when printing xml.

imkerberos · Nov 2, 2011 · 406159c · 406159c
1 parent 34ed84e
commit 406159c
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/KissXML/DDXMLNode.m b/KissXML/DDXMLNode.m
@@ -1065,11 +1065,18 @@ - (NSString *)XMLStringWithOptions:(NSUInteger)options
 		xmlIndentTreeOutput = 1;
 	}
 
+	int dumpCnt;
+
 	xmlBufferPtr bufferPtr = xmlBufferCreate();
 	if (IsXmlNsPtr(genericPtr))
-		xmlNodeDump(bufferPtr, NULL, (xmlNodePtr)genericPtr, 0, format);
+		dumpCnt = xmlNodeDump(bufferPtr, NULL, (xmlNodePtr)genericPtr, 0, format);
 	else
-		xmlNodeDump(bufferPtr, ((xmlStdPtr)genericPtr)->doc, (xmlNodePtr)genericPtr, 0, format);
+		dumpCnt = xmlNodeDump(bufferPtr, ((xmlStdPtr)genericPtr)->doc, (xmlNodePtr)genericPtr, 0, format);
+
+	if (dumpCnt < 0)
+	{
+		return nil;
+	}
 
 	if ([self kind] == DDXMLTextKind)
 	{