[feat-7] Token Location Cookie Parsing 지원 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iml1111
requested changes
Aug 1, 2022
django_jwt_extended/apps.py
Outdated
| @@ -23,6 +23,7 @@ def ready(self): | |||
| self.access_token_expires = data.access_token_expires | |||
| self.refresh_token_expires = data.refresh_token_expires | |||
| self.token_header_name = 'Authorization' | |||
| self.token_cookie_name = data.token_cookie_name | |||
There was a problem hiding this comment.
액세스 쿠키 이름, 리프레시 쿠키 이름을 나눠야 하지 않을까 싶습니다
There was a problem hiding this comment.
아 secure 옵션으로 인해 쿠키조작이 불가능한거였구나
akshxl09
commented
Aug 1, 2022
|
|
||
| elif refresh and config.refresh_cookie_name in request.COOKIES: | ||
| return request.COOKIES[config.refresh_cookie_name], location | ||
|
|
There was a problem hiding this comment.
refresh를 받아서 구분할 수 있도록 만들어봤읍니다. @iml1111
There was a problem hiding this comment.
지금와서 보니까 COOKIES가 get 메소드를 가지고 있다면 아래와 같이 작성해볼 수도 있을듯.
if not refresh:
return request.COOKIES.get(config.access_cookie_name), location
elif refresh:
return request.COOKIES.get(config.refresh_cookie_name), location위에 headers도 똑같은 방식으로 가능할 것 같기도 하고?
iml1111
requested changes
Aug 2, 2022
django_jwt_extended/apps.py
Outdated
| @@ -23,7 +23,8 @@ def ready(self): | |||
| self.access_token_expires = data.access_token_expires | |||
| self.refresh_token_expires = data.refresh_token_expires | |||
| self.token_header_name = 'Authorization' | |||
| self.token_cookie_name = data.token_cookie_name | |||
| self.access_cookie_name = data.access_cookie_name | |||
| self.refresh_cookie_name = data.refresh_cookie_name | |||
There was a problem hiding this comment.
access_token_cookie_name
refresh_token_cookie_name
으로 하는게 어떨까 싶음
|
|
||
| elif refresh and config.refresh_cookie_name in request.COOKIES: | ||
| return request.COOKIES[config.refresh_cookie_name], location | ||
|
|
There was a problem hiding this comment.
지금와서 보니까 COOKIES가 get 메소드를 가지고 있다면 아래와 같이 작성해볼 수도 있을듯.
if not refresh:
return request.COOKIES.get(config.access_cookie_name), location
elif refresh:
return request.COOKIES.get(config.refresh_cookie_name), location위에 headers도 똑같은 방식으로 가능할 것 같기도 하고?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #7