Change GetAllUsersInOrganization signature.

immense · Apr 20, 2021 · 91ce649 · 91ce649
1 parent 2bb3de6
commit 91ce649
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 7 deletions.
diff --git a/Server/Pages/GetSupport.cshtml.cs b/Server/Pages/GetSupport.cshtml.cs
@@ -48,7 +48,7 @@ public async Task<IActionResult> OnPost(string deviceID)
             var alertMessage = string.Join("  ", alertParts);
             await _dataService.AddAlert(deviceID, orgID, alertMessage);
 
-            var orgUsers = _dataService.GetAllUsersInOrganization(orgID);
+            var orgUsers = await _dataService.GetAllUsersInOrganization(orgID);
             var emailMessage = string.Join("<br />", alertParts);
             foreach (var user in orgUsers)
             {

diff --git a/Server/Pages/ManageOrganization.razor.cs b/Server/Pages/ManageOrganization.razor.cs
@@ -227,7 +227,8 @@ private async Task RefreshData()
 
             _invites.AddRange(DataService.GetAllInviteLinks(Username).OrderBy(x => x.InvitedUser));
             _deviceGroups.AddRange(DataService.GetDeviceGroups(Username).OrderBy(x => x.Name));
-            _orgUsers.AddRange(DataService.GetAllUsersInOrganization(Username).OrderBy(x => x.UserName));
+            var orgUsers = await DataService.GetAllUsersInOrganization(User.OrganizationID);
+            _orgUsers.AddRange(orgUsers.OrderBy(x => x.UserName));
         }
         private async Task ResetPassword(RemotelyUser user)
         {

diff --git a/Server/Services/DataService.cs b/Server/Services/DataService.cs
@@ -106,7 +106,7 @@ public interface IDataService
 
         RemotelyUser[] GetAllUsersForServer();
 
-        RemotelyUser[] GetAllUsersInOrganization(string userName);
+        Task<RemotelyUser[]> GetAllUsersInOrganization(string orgId);
 
         ApiToken GetApiKey(string keyId);
 
@@ -1093,17 +1093,20 @@ public RemotelyUser[] GetAllUsersForServer()
             return dbContext.Users.ToArray();
         }
 
-        public RemotelyUser[] GetAllUsersInOrganization(string userName)
+        public async Task<RemotelyUser[]> GetAllUsersInOrganization(string orgId)
         {
-            if (string.IsNullOrWhiteSpace(userName))
+            if (string.IsNullOrWhiteSpace(orgId))
             {
                 return Array.Empty<RemotelyUser>();
             }
 
             using var dbContext = _dbFactory.CreateDbContext();
 
-            var user = dbContext.Users.FirstOrDefault(x => x.UserName == userName);
-            return dbContext.Users.Where(x => x.OrganizationID == user.OrganizationID).ToArray();
+            var organization = await dbContext.Organizations
+                .Include(x => x.RemotelyUsers)
+                .FirstOrDefaultAsync(x => x.ID == orgId);
+
+            return organization.RemotelyUsers.ToArray();
         }
 
         public ApiToken GetApiKey(string keyId)