Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert AgentHub to use strongly-typed clients. #702

Merged
merged 1 commit into from Aug 4, 2023

Conversation

bitbound
Copy link
Collaborator

@bitbound bitbound commented Aug 3, 2023

Changes:

  • Convert AgentHub to use strongly-typed clients.
  • Changed scoped services to singletons in Agent, since they are effectively singletons in a desktop app.
    • Scoped is really for web apps, where the scope is created for each request.
  • If agent is running un-elevated on Windows, CpuUtilizationSampler will now skip processes in session 0.
    • These will throw when unelevated (e.g. when debugging).

Please read the following. Do not delete below this line.

Thank you for your contribution to the Remotely project. It is required that contributors assign copyright to Immense Networks so we retain full ownership of the project.

This makes it easier for other entities to use the software because they only have to deal with one copyright holder. It also gives me assurance that we'll be able to make decisions in the future without gathering and consulting all contributors.

While this may seem odd, many open source maintainers practice this. Here are a couple well-known examples:

A nice article on the topic can be found here: https://haacked.com/archive/2006/01/26/WhoOwnstheCopyrightforAnOpenSourceProject.aspx/

By submitting this PR, you agree to the following:

You hereby assign copyright in this PR's code to the Remotely project and its copyright holder, Immense Networks, to be licensed under the same terms as the rest of the code. You agree to relinquish any and all copyright interest in the software, to the detriment of your heirs and successors.

@bitbound bitbound self-assigned this Aug 3, 2023
Base automatically changed from tech/remove-agent-staticdependencies to master August 4, 2023 15:22
@bitbound bitbound merged commit 75a2a56 into master Aug 4, 2023
@bitbound bitbound deleted the tech/strongly-typed-hub-clients branch August 4, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants