Minor build fixes after tsup migration

immerjs · Apr 15, 2023 · 46cd1d5 · 46cd1d5
1 parent d5be8f2
commit 46cd1d5
Show file tree

Hide file tree

Showing 9 changed files with 17 additions and 19 deletions.
diff --git a/jest.config.build.js b/jest.config.build.js
@@ -1,6 +1,6 @@
 module.exports = {
 	moduleNameMapper: {
-		"src/.*": "<rootDir>/dist/immer.cjs.production.min.js"
+		"src/.*": "<rootDir>/dist/cjs/immer.cjs.production.js"
 	},
 	testEnvironmentOptions: {
 		url: "http://localhost"

diff --git a/jest.config.js b/jest.config.js
@@ -2,9 +2,6 @@ module.exports = {
 	testEnvironmentOptions: {
 		url: "http://localhost"
 	},
-	globals: {
-		__DEV__: true
-	},
 	preset: "ts-jest/presets/js-with-ts",
 	testEnvironment: "node",
 	testMatch: ["**/__tests__/**/*.[jt]s?(x)"]

diff --git a/package.json b/package.json
@@ -17,10 +17,11 @@
   "types": "./dist/immer.d.ts",
   "sideEffects": false,
   "scripts": {
+    "pretest": "yarn build",
     "test": "jest && yarn test:build && yarn test:flow",
     "test:perf": "cd __performance_tests__ && node add-data.mjs && node todo.mjs && node incremental.mjs && node large-obj.mjs",
     "test:flow": "yarn flow check __tests__/flow",
-    "test:build": "yarn build && NODE_ENV='production' yarn jest --config jest.config.build.js",
+    "test:build": "NODE_ENV='production' yarn jest --config jest.config.build.js",
     "watch": "jest --watch",
     "coverage": "jest --coverage",
     "coveralls": "jest --coverage && cat ./coverage/lcov.info | ./node_modules/.bin/coveralls && rm -rf ./coverage",

diff --git a/src/core/finalize.ts b/src/core/finalize.ts
@@ -116,7 +116,7 @@ function finalizeProperty(
 	rootPath?: PatchPath,
 	targetIsSet?: boolean
 ) {
-	if (process.env.NODE_ENV === "development" && childValue === targetObject)
+	if (process.env.NODE_ENV !== "production" && childValue === targetObject)
 		die(5)
 	if (isDraft(childValue)) {
 		const path =

diff --git a/src/core/proxy.ts b/src/core/proxy.ts
@@ -221,14 +221,14 @@ each(objectTraps, (key, fn) => {
 	}
 })
 arrayTraps.deleteProperty = function(state, prop) {
-	if (process.env.NODE_ENV === "development" && isNaN(parseInt(prop as any)))
+	if (process.env.NODE_ENV !== "production" && isNaN(parseInt(prop as any)))
 		die(13)
 	// @ts-ignore
 	return arrayTraps.set!.call(this, state, prop, undefined)
 }
 arrayTraps.set = function(state, prop, value) {
 	if (
-		process.env.NODE_ENV === "development" &&
+		process.env.NODE_ENV !== "production" &&
 		prop !== "length" &&
 		isNaN(parseInt(prop as any))
 	)

diff --git a/src/plugins/patches.ts b/src/plugins/patches.ts
@@ -25,7 +25,7 @@ import {
 
 export function enablePatches() {
 	const errorOffset = 16
-	if (process.env.NODE_ENV === "development") {
+	if (process.env.NODE_ENV !== "production") {
 		errors.push(
 			'Sets cannot have "replace" patches.',
 			function(op: string) {

diff --git a/src/utils/errors.ts b/src/utils/errors.ts
@@ -1,5 +1,5 @@
 export const errors =
-	process.env.NODE_ENV === "development"
+	process.env.NODE_ENV !== "production"
 		? [
 				// All error codes, starting by 0:
 				function(plugin: string) {
@@ -37,7 +37,7 @@ export const errors =
 		: []
 
 export function die(error: number, ...args: any[]): never {
-	if (process.env.NODE_ENV === "development") {
+	if (process.env.NODE_ENV !== "production") {
 		const e = errors[error]
 		const msg = typeof e === "function" ? e.apply(null, args as any) : e
 		throw new Error(`[Immer] ${msg}`)

diff --git a/website/docs/installation.mdx b/website/docs/installation.mdx
@@ -63,10 +63,10 @@ Import size report for immer:
 ┌───────────────────────┬───────────┬────────────┬───────────┐
 │        (index)        │ just this │ cumulative │ increment │
 ├───────────────────────┼───────────┼────────────┼───────────┤
-│ import * from 'immer' │   5873    │     0      │     0     │
-│        produce        │   3421    │    3421    │     0     │
-│     enableMapSet      │   4837    │    4845    │   1424    │
-│     enablePatches     │   4240    │    5655    │    810    │
+│ import * from 'immer' │   5033    │     0      │     0     │
+│        produce        │   3324    │    3324    │     0     │
+│     enableMapSet      │   4030    │    4039    │    715    │
+│     enablePatches     │   4112    │    4826    │    787    │
 └───────────────────────┴───────────┴────────────┴───────────┘
 (this report was generated by npmjs.com/package/import-size)
 ```

diff --git a/website/i18n/zh-CN/docusaurus-plugin-content-docs/current/installation.mdx b/website/i18n/zh-CN/docusaurus-plugin-content-docs/current/installation.mdx
@@ -64,10 +64,10 @@ Import size report for immer:
 ┌───────────────────────┬───────────┬────────────┬───────────┐
 │        (index)        │ just this │ cumulative │ increment │
 ├───────────────────────┼───────────┼────────────┼───────────┤
-│ import * from 'immer' │   5873    │     0      │     0     │
-│        produce        │   3421    │    3421    │     0     │
-│     enableMapSet      │   4837    │    4845    │   1424    │
-│     enablePatches     │   4240    │    5655    │    810    │
+│ import * from 'immer' │   5033    │     0      │     0     │
+│        produce        │   3324    │    3324    │     0     │
+│     enableMapSet      │   4030    │    4039    │    715    │
+│     enablePatches     │   4112    │    4826    │    787    │
 └───────────────────────┴───────────┴────────────┴───────────┘
 (this report was generated by npmjs.com/package/import-size)
 ```