Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance chart is broken #445

Closed
TheRusskiy opened this issue Oct 21, 2019 · 2 comments
Closed

Performance chart is broken #445

TheRusskiy opened this issue Oct 21, 2019 · 2 comments
Labels

Comments

@TheRusskiy
Copy link

🐛 Bug Report

Looking at the performance section of documentation the description doesn't make sense.
Either performance tests are broken or the description is out of date.

Currently, it looks like this, which means Immer is the slowest of them all:

Screenshot 2019-10-21 at 19 28 16

To Reproduce

Look at https://immerjs.github.io/immer/docs/performance.

Expected behavior

On some blog I found this picture, the description does make sense for it:
Screenshot 2019-10-21 at 19 24 37
(https://hackernoon.com/introducing-immer-immutability-the-easy-way-9d73d8f71cb3)

mweststrate added a commit that referenced this issue Oct 30, 2019
@mweststrate
Copy link
Collaborator

Will be fixed by next release. Somehow scale got changed to logarithmic.

@aleclarson
Copy link
Member

🎉 This issue has been resolved in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants