-
-
Notifications
You must be signed in to change notification settings - Fork 850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to always invoke getters #584
Comments
I have similar requirements. It's much more painful than it used to be. The only way I could get it working was by the following steps:
It's much more of a maintenance pain and the patch is far larger. I worry it scares people who look at it. I dream of getters being configurably supported, but can respect they are not in scope for this project. If you work out a better way please let me know. |
🎉 This issue has been resolved in version 7.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉 |
🙋♂ Question
Follow up to this thread: #317
Where I am using immer is somewhat different to most use cases I would imagine. The application I am working on is set up with a micro front end style of architecture. We have a "shell" application with a global redux store that brings them all in and individual apps can be of any framework. We are mostly vuejs right now, which is where the issue comes. Due to this line:
immer/src/utils/common.ts
Line 159 in 0d87fc8
Would it be possible to have an option to always call the get function? Our redux store lives outside of the vue application and thus has no need for the reactivity that vue is adding with it's getter/setters. So far we have gotten around this by using patch-package to edit immer and remove the error throw. With version 6+ of immer, it doesn't look to be viable anymore as the code being bundled is all minified/uglified.
Would certainly be willing to make a contribution if this is something that can be added.
The text was updated successfully, but these errors were encountered: