Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs site URL structure has changed and broken external links #772

Closed
markerikson opened this issue Mar 21, 2021 · 3 comments
Closed

Docs site URL structure has changed and broken external links #772

markerikson opened this issue Mar 21, 2021 · 3 comments
Labels

Comments

@markerikson
Copy link
Contributor

🐛 Bug Report

A clear and concise description of what the bug is.

It looks like Immer has just switched over to Docusaurus v2, which is nice. However, in the process, the URL structure has changed - there's no longer a /docs/ segment. This has changed the URL of every page in the docs site and broken external links. For example, the "Returning Values" page used to be at https://immerjs.github.io/immer/docs/return , and now it's at https://immerjs.github.io/immer/return , so the old URL gives a 404.

If the docs were hosted on Netlify, you could use their _redirects file to point the old URLs to the new URLs (I've done that a lot with the Redux docs).

A quick search suggests that Github Pages does not provide server-side redirects. It looks like Docusaurus does have a "client-side redirects" plugin at https://v2.docusaurus.io/docs/api/plugins/@docusaurus/plugin-client-redirects . It would be great if you could set that up and redirect all the old links to the current pages.

@mweststrate
Copy link
Collaborator

Should be fixed now!

@markerikson
Copy link
Contributor Author

Sweet, works correctly now. Thank you for the fast response! :)

@mweststrate
Copy link
Collaborator

🎉 This issue has been resolved in version 9.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants