Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove superfluous argument: key #206

Merged
merged 2 commits into from
Oct 13, 2018
Merged

Remove superfluous argument: key #206

merged 2 commits into from
Oct 13, 2018

Conversation

styfle
Copy link
Contributor

@styfle styfle commented Sep 30, 2018

It looks like createState() only accepts 2 arguments, not 3.

This removes the third argument: key

@coveralls
Copy link

coveralls commented Sep 30, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 93.28% when pulling 6cdde54 on styfle:patch-1 into c41b4ab on mweststrate:master.

aleclarson
aleclarson reviewed Oct 3, 2018
View reviewed changes
Copy link
Member

@aleclarson aleclarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the key argument of createProxy too.

@styfle
Copy link
Contributor Author

styfle commented Oct 3, 2018

@aleclarson Good call! I fixed it 🔧

@aleclarson aleclarson merged commit 09d69ae into immerjs:master Oct 13, 2018
@styfle styfle deleted the patch-1 branch October 13, 2018 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleclarson aleclarson aleclarson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@styfle @coveralls @aleclarson