Abuse typescript generics to show the error message for calls to die
#669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1acba46:
|
forivall
force-pushed
the
doc/die-ts-hover
branch
from
a02b658
to
1acba46
Compare
forivall
commented
Sep 11, 2020
| @@ -1,8 +1,9 @@ | |||
| type S = string & {} | |||
There was a problem hiding this comment.
In ts < 4, this prevents the const string literal from merging with the string type. can be removed to just "string" in ts 4.0+
|
Closing as this makes the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc: add generic to die to show what the error number meansMostly, I did this to help me understand the error codes quicker as i'm looking through how immer works.
Feel free to close if you don't want this in your codebase.