Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make declarations work without ts proxy lib #718 #721

Closed
wants to merge 2 commits into from

Conversation

Bnaya
Copy link

@Bnaya Bnaya commented Dec 10, 2020

Fix #718,
Restructure files structure so on consuming project, when importing symbols from the package top level,
It will not load any d.ts file that references Proxy related types.

Feel free to suggest other files names/split :)

Oh and i have that ugly withoutActualValueSymbolThisFileIsGoneInTypesDonooWhy.toString thing,
that without it, something in the toolchain made proxyStateTypes not appear in the final dist dir, means broken declarations
(when compiling with tsc it worked properly)

Testing:
I couldn't see any infra to test types,
Did a local check.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 10, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit abb4e3c:

Sandbox Source
Immer sandbox Configuration

@Bnaya Bnaya force-pushed the es5-compatible-declarations branch from ee6bce7 to 305598f Compare December 10, 2020 12:33
@Bnaya Bnaya marked this pull request as ready for review December 10, 2020 12:53
@octogonz
Copy link

👍👍 I have confirmed that this eliminates the compile error that I reported in #718

Thank you very much for the quick fix!

@mweststrate
Copy link
Collaborator

Giving the low need for this fix and the in the meantime conflicting code, I'll close the PR for now unless there's heavy objections :)

@mweststrate mweststrate closed this Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compile error for TypeScript projects that transpile to ES5
3 participants