ImmerHook return type, Dispatch type fix #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [acorn](https://github.com/acornjs/acorn) from 6.1.1 to 6.4.1. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@6.1.1...6.4.1) Signed-off-by: dependabot[bot] <support@github.com>
Previously, this called `produce()` on every render but discarded the result on every render where `reducer` didn't change. Now, we use useMemo, which only calls it when `reducer` changes. (useCallback is really only intended for a function literal first argument.)
…orn-6.4.1 Bump acorn from 6.1.1 to 6.4.1
useImmerReducer: only call produce() when reducer changes
|
Released in 0.4.0, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I've encountered a situation where I needed the return type of
useImmer<T>, however TypeScript'sReturnType<T>doesn't work with generic return types (microsoft/TypeScript#26856).I would like to add a type alias for this return type (
[T, (f: (d: Draft<T>) => T | void) => void]) calledImmerHook(feel free to rename it appropriately).Also I have noticed the
useImmerReducer<S, A>usesReact.Dispatch, howeverReactis not imported. Is this intended ? I have fixed it by adding{Dispatch}import.