Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useImmerReducer: only call produce() when reducer changes #50

Merged
merged 1 commit into from
Apr 6, 2020
Merged

useImmerReducer: only call produce() when reducer changes #50

merged 1 commit into from
Apr 6, 2020

Commits on Apr 5, 2020

  1. useImmerReducer: only call produce() when reducer changes 

    Previously, this called `produce()` on every render but discarded the result on every render where `reducer` didn't change. Now, we use useMemo, which only calls it when `reducer` changes. (useCallback is really only intended for a function literal first argument.)
    @sophiebits
    sophiebits committed Apr 5, 2020
    Configuration menu
    Copy the full SHA
    751c448 View commit details
    Browse the repository at this point in the history