Merge pull request #103 from immers-space/node-18

Node 18
immers-space · Oct 4, 2023 · 3f4f8a0 · 3f4f8a0
2 parents 258fd6b + ad292db
commit 3f4f8a0
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml
@@ -15,8 +15,7 @@ jobs:
 
     strategy:
       matrix:
-        # tests fail on 18.x see #87
-        node-version: [14.x, 16.x]
+        node-version: [16.x, 18.x]
         mongodb-version: ['5.0']
 
     steps:

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## Unreleased
+* Add [nock fetch work around](https://github.com/nock/nock/issues/2397) to fix tests in node 18.
+* Adjust workflow to run tests using node 18 and 16. Don't run tests against 14.
+
 ## v4.4.1 (2023-06-23)
 
 ### Fixed

diff --git a/package.json b/package.json
@@ -8,7 +8,7 @@
     "npm": ">=7"
   },
   "scripts": {
-    "test": "jasmine",
+    "test": "node --no-experimental-fetch node_modules/jasmine/bin/jasmine",
     "coverage": "nyc npm test && nyc report --reporter=text-lcov > lcov.info",
     "lint": "standard"
   },