Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linting to scripts and CI checks, fix existing lint #77

Merged
merged 1 commit into from
Jan 2, 2023
Merged

Add linting to scripts and CI checks, fix existing lint #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,4 @@ services:
jobs:
- script: 'npm test'
- script: 'npm run coverage'
- script: 'npm run lint'
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
},
"scripts": {
"test": "jasmine",
"coverage": "nyc npm test && nyc report --reporter=text-lcov | coveralls"
"coverage": "nyc npm test && nyc report --reporter=text-lcov | coveralls",
"lint": "standard"
},
"repository": {
"type": "git",
Expand Down
4 changes: 2 additions & 2 deletions store/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ class ApexStore extends IApexStore {
getObject (id, includeMeta) {
return this.db
.collection('objects')
.find({ id: id })
.find({ id })
.limit(1)
// strict comparison as we don't want to return private keys on accident
.project(includeMeta === true ? this.metaProj : this.projection)
Expand Down Expand Up @@ -135,7 +135,7 @@ class ApexStore extends IApexStore {

getActivity (id, includeMeta) {
return this.db.collection('streams')
.find({ id: id })
.find({ id })
.limit(1)
.project(includeMeta ? this.metaProj : this.projection)
.next()
Expand Down