Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: late registration #56

Merged
merged 7 commits into from
Dec 26, 2021
Merged

Conversation

wmurphyrd
Copy link
Member

New feature to allow guests to join spaces, controlled by IMMERS_ALLOW_GUESTS environment var or meta tag

  • Allow people to join as guest without creating an account
    • For the most part. this "just works" for the not-logged-in user because we already had Immers features gated on authorization scopes and they just don't have any scopes authorized
  • For logged-in users interacting with guest users, update the hover menu (block-button, follow-button) based on whether the remote user is logged in (remove add friend, block becomes hide)
  • Add "Claim account" prompts to allow registration later during session (this will prefill your current name in the reg. form and save your current avatar to your profile after it is created)
    • Desktop prompt is in bottom toolbar
    • VR prompt is in HUD (there seems to be a bug in Hubs's VR->2D->VR flow such that the room will be crashed when you come back, but it looks like this is fixed in the most recent Hubs Cloud release)
  • Fix a bug in the popup auth flow that was preventing detection of when the popup closed

image

image
image
image

immers-space/immers#39 is not required for this to work, but it does work well with the late registration flow so that the display name doesn't have to be entered

@wmurphyrd wmurphyrd merged commit 0c2c674 into immers-integration Dec 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant