Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of FrozenArray<>s in dictionaries is unnecessary and bad #116

Open
Tracked by #1399
domenic opened this issue Apr 3, 2024 · 1 comment · May be fixed by #118
Open
Tracked by #1399

Use of FrozenArray<>s in dictionaries is unnecessary and bad #116

domenic opened this issue Apr 3, 2024 · 1 comment · May be fixed by #118

Comments

@domenic
Copy link

domenic commented Apr 3, 2024

The spec has two "init" dictionaries which accept FrozenArray<XRHitTestTrackableType>.

It's not clear what was intended here. But per the Web IDL spec, almost the exact same set of values are accepted compared to accepting the more conventional sequence<XRHitTestTrackableType>.

(The difference is that certain proxies for arrays, which define throwing getOwnPropertyDescriptor() traps, would be rejected, because in theory the implementation is supposed to freeze the incoming array.)

We'd like to prohibit the usage of FrozenArray<T> as a dictionary member in Web IDL, per whatwg/webidl#1399. It would be lovely if you could move to using sequence<>s.

@domenic
Copy link
Author

domenic commented Jun 5, 2024

Ping on getting this updated! This is the last use of FrozenArray<> in a dictionary on the platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant