Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor spec to be subscription based #11

Open
kearwood opened this issue Aug 5, 2019 · 2 comments
Open

Refactor spec to be subscription based #11

kearwood opened this issue Aug 5, 2019 · 2 comments
Assignees

Comments

@kearwood
Copy link
Contributor

kearwood commented Aug 5, 2019

Feedback from the W3C F2F meeting and feedback on the initial PR is supporting the pattern of "subscribing" to values that change from frame to frame, rather than resolving a promise each frame. We should refactor XRFrame.getGlobalLightEstimate() and XRFrame.getGlobalReflectionProbe() to be subscription based. This should be cohesive with the subscription pattern proposed for XR hit testing.

@kearwood kearwood self-assigned this Aug 6, 2019
@kearwood
Copy link
Contributor Author

kearwood commented Feb 4, 2020

If we are to activate the global ambient estimation via a feature policy flag, that could suffice to be an indication to the UA that the XRSession is subscribing to light estimation updates. If we are later supporting local light estimation, the subscription for each probe would be instantiated after XRSession creation.

@kearwood
Copy link
Contributor Author

kearwood commented Feb 4, 2020

Perhaps we could proceed by describing this module as "Global Lighting Estimation" and, if there is enough interest, later define a "Local Lighting Estimation" module which builds on this with a subscription-based request for lighting localized around a hit test location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant