Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide custom URL to DPDB #274

Closed
danrossi opened this issue Jul 26, 2017 · 6 comments
Closed

Provide custom URL to DPDB #274

danrossi opened this issue Jul 26, 2017 · 6 comments

Comments

@danrossi
Copy link

There is an enforcement to load a remote json. However it is out of date to the github version and missing Samsung S8 (webvr fully functional with flags enabled).

Needs an option to use updated cache or custom url ?

@cvan
Copy link
Contributor

cvan commented Aug 3, 2017

Can you check immersive-web/webvr-polyfill-dpdb#23 (comment)

and, yes, we can support a custom URL to use instead

@danrossi
Copy link
Author

danrossi commented Aug 5, 2017

That is for S8+ not S8. different codes. S8+ has a bigger screen. i had to add it to a custom device json. according to the code the url is a constant.

@cvan
Copy link
Contributor

cvan commented Sep 6, 2017

this has since been updated. we should still keep this issue open to allow providing a different URL to the JSON file for a custom DPDB.

@danrossi
Copy link
Author

danrossi commented Sep 6, 2017

It's ok thanks for that. I had to fork and modify myself to get S8 working.

@jsantell jsantell changed the title Option to prevent loading webvr rocks device data Provide custom URL to DPDB Sep 12, 2017
@jsantell
Copy link
Contributor

Updating issue title -- please update with a new issue if you're still seeing issues with S8 after updating. Thanks!

@jsantell
Copy link
Contributor

Added in cardboard-vr-display 1.0.1, and webvr-polyfill 0.10.0, there's now a DPDB_URL config option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants