add unit tests

immich-app · Mar 17, 2024 · 1bfd568 · 1bfd568
1 parent 7dff742
commit 1bfd568
Show file tree

Hide file tree

Showing 2 changed files with 50 additions and 1 deletion.
diff --git a/server/src/domain/library/library.service.spec.ts b/server/src/domain/library/library.service.spec.ts
@@ -147,6 +147,26 @@ describe(LibraryService.name, () => {
     });
   });
 
+  describe('validateConfig', () => {
+    it('should allow a valid cron expression', () => {
+      expect(() =>
+        sut.validateConfig({
+          newConfig: { library: { scan: { cronExpression: '0 0 * * *' } } } as SystemConfig,
+          oldConfig: {} as SystemConfig,
+        }),
+      ).not.toThrow(expect.stringContaining('Invalid cron expression'));
+    });
+
+    it('should fail for an invalid cron expression', () => {
+      expect(() =>
+        sut.validateConfig({
+          newConfig: { library: { scan: { cronExpression: 'foo' } } } as SystemConfig,
+          oldConfig: {} as SystemConfig,
+        }),
+      ).toThrow(/Invalid cron expression.*/);
+    });
+  });
+
   describe('handleQueueAssetRefresh', () => {
     it('should queue new assets', async () => {
       const mockLibraryJob: ILibraryRefreshJob = {

diff --git a/server/src/domain/storage-template/storage-template.service.spec.ts b/server/src/domain/storage-template/storage-template.service.spec.ts
@@ -12,7 +12,7 @@ import {
   StorageTemplateService,
   defaults,
 } from '@app/domain';
-import { AssetPathType, SystemConfigKey } from '@app/infra/entities';
+import { AssetPathType, SystemConfig, SystemConfigKey } from '@app/infra/entities';
 import {
   assetStub,
   newAlbumRepositoryMock,
@@ -74,6 +74,35 @@ describe(StorageTemplateService.name, () => {
     SystemConfigCore.create(configMock).config$.next(defaults);
   });
 
+  describe('validate', () => {
+    it('should allow valid templates', () => {
+      expect(() =>
+        sut.validate({
+          newConfig: {
+            storageTemplate: {
+              template:
+                '{{y}}{{M}}{{W}}{{d}}{{h}}{{m}}{{s}}{{filename}}{{ext}}{{filetype}}{{filetypefull}}{{assetId}}{{album}}',
+            },
+          } as SystemConfig,
+          oldConfig: {} as SystemConfig,
+        }),
+      ).not.toThrow();
+    });
+
+    it('should fail for an invalid template', () => {
+      expect(() =>
+        sut.validate({
+          newConfig: {
+            storageTemplate: {
+              template: '{{foo}}',
+            },
+          } as SystemConfig,
+          oldConfig: {} as SystemConfig,
+        }),
+      ).toThrow(/Invalid storage template.*/);
+    });
+  });
+
   describe('handleMigrationSingle', () => {
     it('should skip when storage template is disabled', async () => {
       configMock.load.mockResolvedValue([{ key: SystemConfigKey.STORAGE_TEMPLATE_ENABLED, value: false }]);