pr feedback

immich-app · Mar 21, 2024 · 524224d · 524224d
1 parent 4d9a8ac
commit 524224d
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 10 deletions.
diff --git a/web/src/lib/components/asset-viewer/asset-viewer.svelte b/web/src/lib/components/asset-viewer/asset-viewer.svelte
@@ -571,7 +571,7 @@
           onSetToFullScreen={() => assetViewerHtmlElement.requestFullscreen()}
           onPrevious={() => navigateAsset('previous')}
           onNext={() => navigateAsset('next')}
-          onClose={handleStopSlideshow}
+          onClose={() => ($slideshowState = SlideshowState.StopSlideshow)}
         />
       </div>
     {/if}

diff --git a/web/src/lib/components/asset-viewer/slideshow-bar.svelte b/web/src/lib/components/asset-viewer/slideshow-bar.svelte
@@ -116,5 +116,5 @@
   duration={$slideshowDelay}
   bind:this={progressBar}
   bind:status={progressBarStatus}
-  onDone={handleDone}
+  on:done={handleDone}
 />
diff --git a/web/src/lib/components/shared-components/progress-bar/progress-bar.svelte b/web/src/lib/components/shared-components/progress-bar/progress-bar.svelte
@@ -8,7 +8,7 @@
 <script lang="ts">
   import { handlePromiseError } from '$lib/utils';
 
-  import { onMount } from 'svelte';
+  import { createEventDispatcher, onMount } from 'svelte';
   import { tweened } from 'svelte/motion';
 
   /**
@@ -26,10 +26,6 @@
 
   export let duration = 5;
 
-  export let onDone: () => void;
-  export let onPlaying: (() => void) | undefined = undefined;
-  export let onPaused: (() => void) | undefined = undefined;
-
   const onChange = async () => {
     progress = setDuration(duration);
     await play();
@@ -41,10 +37,16 @@
 
   $: {
     if ($progress === 1) {
-      onDone();
+      dispatch('done');
     }
   }
 
+  const dispatch = createEventDispatcher<{
+    done: void;
+    playing: void;
+    paused: void;
+  }>();
+
   onMount(async () => {
     if (autoplay) {
       await play();
@@ -53,13 +55,13 @@
 
   export const play = async () => {
     status = ProgressBarStatus.Playing;
-    onPlaying && onPlaying();
+    dispatch('playing');
     await progress.set(1);
   };
 
   export const pause = async () => {
     status = ProgressBarStatus.Paused;
-    onPaused && onPaused();
+    dispatch('paused');
     await progress.set($progress);
   };