fix(mobile): back button while multiselecting showing the last select…

…ed image (#1521)
immich-app · Feb 2, 2023 · 5d6559e · 5d6559e · vercel · Feb 2, 2023
1 parent 29c79ad
commit 5d6559e
Show file tree

Hide file tree

Showing 2 changed files with 48 additions and 45 deletions.
diff --git a/mobile/lib/modules/home/ui/asset_grid/immich_asset_grid.dart b/mobile/lib/modules/home/ui/asset_grid/immich_asset_grid.dart
@@ -224,13 +224,28 @@ class ImmichAssetGridState extends State<ImmichAssetGrid> {
     }
   }
 
+
+  Future<bool> onWillPop() async {
+    if (widget.selectionActive && _selectedAssets.isNotEmpty) {
+      _deselectAll();
+      return false;
+    }
+
+    return true;
+  }
+
+
+
   @override
   Widget build(BuildContext context) {
-    return Stack(
-      children: [
-        _buildAssetGrid(),
-        if (widget.selectionActive) _buildMultiSelectIndicator(),
-      ],
+    return WillPopScope(
+      onWillPop: onWillPop,
+      child: Stack(
+        children: [
+          _buildAssetGrid(),
+          if (widget.selectionActive) _buildMultiSelectIndicator(),
+        ],
+      ),
     );
   }
 }

diff --git a/mobile/lib/modules/home/views/home_page.dart b/mobile/lib/modules/home/views/home_page.dart
@@ -200,46 +200,34 @@ class HomePage extends HookConsumerWidget {
         );
       }
 
-      Future<bool> onWillPop() async {
-        if (multiselectEnabled.state) {
-          selectionEnabledHook.value = false;
-          return false;
-        }
-
-        return true;
-      }
-
-      return WillPopScope(
-        onWillPop: onWillPop,
-        child: SafeArea(
-          bottom: !multiselectEnabled.state,
-          top: true,
-          child: Stack(
-            children: [
-              ref.watch(assetProvider).renderList == null ||
-                      ref.watch(assetProvider).allAssets.isEmpty
-                  ? buildLoadingIndicator()
-                  : ImmichAssetGrid(
-                      renderList: ref.watch(assetProvider).renderList!,
-                      allAssets: ref.watch(assetProvider).allAssets,
-                      assetsPerRow: appSettingService
-                          .getSetting(AppSettingsEnum.tilesPerRow),
-                      showStorageIndicator: appSettingService
-                          .getSetting(AppSettingsEnum.storageIndicator),
-                      listener: selectionListener,
-                      selectionActive: selectionEnabledHook.value,
-                    ),
-              if (selectionEnabledHook.value)
-                ControlBottomAppBar(
-                  onShare: onShareAssets,
-                  onDelete: onDelete,
-                  onAddToAlbum: onAddToAlbum,
-                  albums: albums,
-                  sharedAlbums: sharedAlbums,
-                  onCreateNewAlbum: onCreateNewAlbum,
-                ),
-            ],
-          ),
+      return SafeArea(
+        bottom: !multiselectEnabled.state,
+        top: true,
+        child: Stack(
+          children: [
+            ref.watch(assetProvider).renderList == null ||
+                    ref.watch(assetProvider).allAssets.isEmpty
+                ? buildLoadingIndicator()
+                : ImmichAssetGrid(
+                    renderList: ref.watch(assetProvider).renderList!,
+                    allAssets: ref.watch(assetProvider).allAssets,
+                    assetsPerRow: appSettingService
+                        .getSetting(AppSettingsEnum.tilesPerRow),
+                    showStorageIndicator: appSettingService
+                        .getSetting(AppSettingsEnum.storageIndicator),
+                    listener: selectionListener,
+                    selectionActive: selectionEnabledHook.value,
+                  ),
+            if (selectionEnabledHook.value)
+              ControlBottomAppBar(
+                onShare: onShareAssets,
+                onDelete: onDelete,
+                onAddToAlbum: onAddToAlbum,
+                albums: albums,
+                sharedAlbums: sharedAlbums,
+                onCreateNewAlbum: onCreateNewAlbum,
+              ),
+          ],
         ),
       );
     }