Skip to content

Commit

Permalink
fix(cli): Run npm ci in sdk folder before deploying to npm (#6986)
Browse files Browse the repository at this point in the history
* fix cli path

* run npm ci in sdk folder

* version bump

* build sdk before publishing cli

* dry run publish

* build cli

* fix(ci): Push CLI latest tag

* remove dry run flag

---------

Co-authored-by: bo0tzz <git@bo0tzz.me>
  • Loading branch information
etnoy and bo0tzz committed Feb 11, 2024
1 parent 28e4f8e commit 6e853e2
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 10 deletions.
22 changes: 15 additions & 7 deletions .github/workflows/cli.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@ on:
workflow_dispatch:
push:
branches: [main]
paths:
- 'cli/**'
- '.github/workflows/cli.yml'
paths:
- "cli/**"
- ".github/workflows/cli.yml"
pull_request:
branches: [main]
paths:
- 'cli/**'
- '.github/workflows/cli.yml'
paths:
- "cli/**"
- ".github/workflows/cli.yml"

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
Expand All @@ -34,7 +34,12 @@ jobs:
with:
node-version: "20.x"
registry-url: "https://registry.npmjs.org"
- name: Prepare SDK
run: npm ci --prefix ../open-api/typescript-sdk/
- name: Build SDK
run: npm run build --prefix ../open-api/typescript-sdk/
- run: npm ci
- run: npm run build
- run: npm publish
if: ${{ github.event_name == 'workflow_dispatch' }}
env:
Expand Down Expand Up @@ -62,7 +67,7 @@ jobs:
registry: ghcr.io
username: ${{ github.repository_owner }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Get package version
id: package-version
run: |
Expand All @@ -73,10 +78,13 @@ jobs:
id: metadata
uses: docker/metadata-action@v5
with:
flavor: |
latest=false
images: |
name=ghcr.io/${{ github.repository_owner }}/immich-cli
tags: |
type=raw,value=${{ steps.package-version.outputs.version }},enable=${{ github.event_name == 'workflow_dispatch' }}
type=raw,value=latest,enable=${{ github.event_name == 'workflow_dispatch' }}
- name: Build and push image
uses: docker/build-push-action@v5.1.0
Expand Down
6 changes: 3 additions & 3 deletions cli/package.json
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
{
"name": "@immich/cli",
"version": "2.0.7",
"version": "2.0.8",
"description": "Command Line Interface (CLI) for Immich",
"type": "module",
"exports": "./dist/index.js",
"bin": {
"immich": "./dist/index.js"
"immich": "dist/index.js"
},
"license": "MIT",
"keywords": [
Expand Down Expand Up @@ -51,7 +51,7 @@
},
"repository": {
"type": "git",
"url": "github:immich-app/immich",
"url": "git+https://github.com/immich-app/immich.git",
"directory": "cli"
},
"engines": {
Expand Down

0 comments on commit 6e853e2

Please sign in to comment.