Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Immich logo on Shared page takes to immich.app instead #5519

Closed
1 of 3 tasks
anuj-online opened this issue Dec 6, 2023 · 8 comments
Closed
1 of 3 tasks

[BUG] Immich logo on Shared page takes to immich.app instead #5519

anuj-online opened this issue Dec 6, 2023 · 8 comments
Labels
bug Something isn't working good first issue Good for newcomers 🖥️web

Comments

@anuj-online
Copy link

The bug

When a shared album and a link is created (password protected)
Upon click the Immich logo on the top left, the page redirects to immich.app instead of the host url

The OS that Immich Server is running on

Ubuntu 22.10

Version of Immich Server

v1.89.0

Version of Immich Mobile App

v1.89.0 build 129

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

NA

Your .env content

NA

Reproduction steps

1. Run immich and create a share album
2. Share the link with password to other user
3. When user enters the password and previews the gallery (all is fine)
4. Upon clicking the immich logo on top right, the page goes to immich.app, instead of the server url the link is shared from

Additional information

No response

@anuj-online anuj-online added bug Something isn't working needs triage Bug that needs triage from maintainer labels Dec 6, 2023
@bo0tzz bo0tzz added good first issue Good for newcomers 🖥️web and removed needs triage Bug that needs triage from maintainer labels Dec 6, 2023
@jrasm91
Copy link
Contributor

jrasm91 commented Dec 6, 2023

"its a feature not a bug"

@Luvbe3
Copy link

Luvbe3 commented Dec 9, 2023

I think clicking on the icon will redirect you to the shared homepages or the homepages of the web, which is more reasonable than switching to immich.app

JW-CH added a commit to JW-CH/immich that referenced this issue Dec 13, 2023
JW-CH added a commit to JW-CH/immich that referenced this issue Dec 13, 2023
jrasm91 pushed a commit that referenced this issue Dec 13, 2023
* #5519 shared page redirect to host

* #5519 file formatting
@arpanghosh8453
Copy link

Thank you for fixing this. I am waiting for the docker version release!

jonhnet pushed a commit to jonhnet/immich that referenced this issue Dec 15, 2023
@arpanghosh8453
Copy link

I am not sure if I am missing something, I updated to v1.91.0 and restarted my containers, it pulled down the new builds and all, but still I see the same issue with shared links. Any clue what I am doing wrong?

@jrasm91
Copy link
Contributor

jrasm91 commented Dec 16, 2023

I think the PR only fixed it for shared albums not shared individual assets.

@JW-CH
Copy link
Contributor

JW-CH commented Dec 18, 2023

I will have a look and fix it for the shared assets aswell.

@bo0tzz bo0tzz closed this as completed Jan 1, 2024
@Luvbe3
Copy link

Luvbe3 commented Jan 6, 2024

The problem still exists in INDIVIDUAL SHARE

Untitled

@danieldietzler
Copy link
Member

danieldietzler commented Jan 6, 2024

Hey, this has been fixed in #5889 and will be in the next release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers 🖥️web
Projects
None yet
Development

No branches or pull requests

7 participants