-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
faces missing / rescanning does not help #6701
Comments
The default for min recognized faces has been increased from 1 to 3, so if the people you notice no longer appear only had 1 or 2 images, then it may not show them. Does this sound like it could be your issue? |
Unfortunately not. I have now set this to 1 and the problem persists. |
That part is normal. It's a known edge-case that DBSCAN can produce clusters with fewer points than the minimum, but this is benign. It just means there was another person that ended up being a better match. |
It does seem a bit strange that you can upload (almost) the same picture and get a different result. How many users are in this library and how many faces? You can get the face count by running the query |
Regarding different results: The odd thing is that the database has "forgotten" the results. I.e. when such a given group photo was uploaded around ~October last year, the faces were correctly recognized and shown. Since then, they got lost after updates and rescanning did not bring the back. So, it is somewhat ~assuring that the faces get recognized with a freshly uploaded picture. (Please note I change them slightly to make sure they get a different checksum.) But what happened in between is odd and also the fact that rescanning does not fix it. Is there anyway for the rescanning/rerecognizing process (ALL/ALL) to skip over certain pictures? Regarding the database statistics: 5 users29662 images5656 videos17278 faces37 failed file movements |
Hello, For personId 660e9c7a-b8c6-4ce7-87e2-10bdfd2c0025 I have uploaded several pictures over time, but only one is shown under people. My impression has been that several pictures are missing. Indeed, checking this in the database, I can find 5 pictures using the following select statement:
The only difference between the 1 picture which is shown under people for this person and the other 4 pictures which are not shown is that the other 4 pictures are flagged as archived. And to test this, I could confirm that the picture shows up on the people page once isArchived is changed to "f". => Is it intended behaviour that archived pictures do not show up with the respective person under people? Another person 306cb755-34a2-494e-935b-b064afed734f has 18 assets (18 pictures with face recognized), however web interface writes "5 assets" and shows only two pictures. I could figure out
=> Is it intended behaviour that album pictures do not show up with the respective person under people? For me personally, I use archive to get to a nice timeline. I.e. I would like archived pictures to remain in albums and actually, I would prefer them to also show up under people. I don't find it intuitive that the people page does not show all pictures for a given person. Maybe it could be configured if the people pages (location pages, albums, ..) do show archived pictures or not. Of note, this is only partial progress. There are more pictures missing for one of the above persons, which I could find manually in the timeline. It still seems that face detection / recognition results got lost over time and they do not come back with redecting / rerecognizing. Any clues how assets are treated during redetection and rerecognition? Could it be that pictures in albums are being skipped?? |
You have done a great job! I was always wondering why there a so less pictures from my kids and wife recognized. With you work: sure all the pictures are in albums to share them with the grandparents. I hope this will be changed some day. I also prefer to see every photo under the search. Also pictures that were archived and/or in albums. |
I just tested what happens if you archive pictures with GPS coordinates and location tags: They disappear from the page under location tag and also from the world map. This explains why I have several location tags without pictures. 🫠 => Is it intended behavior that archived pictures no longer show up under their location (neither tag nor world map)? |
Thanks for looking into this!
Yes, this is intentional. Some people use archival for sensitive content, so we need to be careful about displaying it.
No, definitely not. We don’t filter by this, so I’m not sure how pictures in albums would be excluded. The query for getting assets with a certain person limits to the 1000 newest assets, so I wonder if this is what you’re noticing. Can you reproduce the album issue? |
|
Of note, the new web based search returns both unarchived and archived pictures. So, now I can search for a person and see the pictures from the archive. Thank god none of my pictures are sensitive content :) |
I guess we weren't careful enough haha 😅 |
Out of curiosity, do you notice any difference for this issue with the current release? My testing with a 400k library showed much better results for recognition recall. |
ok, after moving to a much faster windows PC I could do some more testing. I think I have figured out what is going on:
Both effects together explain why I was under the impressions that faces get "forgotten". I really really wish the users could be allowed to configure how archived pictures get treated. It's one thing to hide the archived pictures from certain searches. But current configuration is not intuitive, even confusing:
|
It's probably fine for facial recognition to include archived images. I can make that change. |
That would be great. Thanks! |
Could this be a setting / toggle in the UI instead? Like with search, where we can toggle between showing archived images or not. |
The discussion was about the facial recognition, not the default settings for the overview. If archived pictures are not scanned you will lose their metadata with the next db reset. That means ultimately that you lose the ability to mine your archive. |
The bug
I am suspecting that my database has accumulated problems since my first docker installation some months ago: While some pictures were initially correctly scanned and faces were shown, these faces have disappeared over time, e.g. after updates and rescans.
A complete redetection/rerecognition with latest version 1.93.3 does not fix the issue. This is actually weird: When I take an affected pictures (including faces), apply a crop to change checksum, I can reupload it and faces will then be recognized. I don't understand why the redetection/rerecognition fails on those other pictures in my database.
The OS that Immich Server is running on
QNAP i386 Linux / Docker
Version of Immich Server
v1.93.3
Version of Immich Mobile App
v1.93.2 build 135
Platform with the issue
Your docker-compose.yml content
Your .env content
Reproduction steps
Additional information
No response
The text was updated successfully, but these errors were encountered: