fix(server): don't return archived assets by default

[mertalev]

Description

The search endpoint doesn't explicitly set withArchived right now, so it won't be part of the query unless the caller sets it to false themselves. This makes it default to false if not provided.

Fixes the behavior described in this comment

[cloudflare-pages]

Deploying with    Cloudflare Pages

Latest commit:	3117ad6
Status:	✅  Deploy successful!
Preview URL:	https://df46f7b8.immich.pages.dev
Branch Preview URL:	https://fix-server-search-archive.immich.pages.dev

View logs

[jrasm91]

Would it be better to just default it in the dto instead? Also, why did you add another asset to the e2e? There was already an archived asset you should have been able to use.

[mertalev]

Would it be better to just default it in the dto instead? Also, why did you add another asset to the e2e? There was already an archived asset you should have been able to use.

There were too many tests failing with this change because they all reference asset3 and it's archived so it doesn't show by default now. I removed the isArchived flag from it and made a separate asset for this.