Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scrollbar always visible for user creation #7190

Closed
1 of 3 tasks
uhthomas opened this issue Feb 18, 2024 · 2 comments · Fixed by #7191
Closed
1 of 3 tasks

scrollbar always visible for user creation #7190

uhthomas opened this issue Feb 18, 2024 · 2 comments · Fixed by #7191

Comments

@uhthomas
Copy link
Member

The bug

The scrollbar is always visible for the user creation dialog. It shouldn't be. I only see this issue on Chromium (linux), and not Firefox.

image

https://demo.immich.app/admin/user-management

The OS that Immich Server is running on

N/A

Version of Immich Server

v1.94.1

Version of Immich Mobile App

N/A

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

N/A

Your .env content

N/A

Reproduction steps

N/A

Additional information

No response
@uhthomas
Copy link
Member Author

Possibly caused by the overflow-y-scroll class? Should probably be overflow-y-auto.

immich/web/src/lib/components/forms/create-user-form.svelte

Line 76 in ddae707

class="max-h-screen w-[500px] max-w-[95vw] overflow-y-scroll rounded-3xl border bg-immich-bg p-4 py-8 shadow-sm dark:border-immich-dark-gray dark:bg-immich-dark-gray dark:text-immich-dark-fg"

Introduced by #3422.

@uhthomas
Copy link
Member Author

Here as well.

image

uhthomas added a commit that referenced this issue Feb 19, 2024
@uhthomas
fix: only show scrollbars if needed
6814818 
The class 'overflow-y-scroll' will always show the scrollbar. Changing
this to 'overflow-y-auto' will only show the scrollbar when needed.

All instances of the 'overflow-y-scroll' class have been changed.

Fixes: #7190
@uhthomas uhthomas mentioned this issue Feb 19, 2024
Merged
alextran1502 pushed a commit that referenced this issue Feb 19, 2024
@uhthomas
fix: only show scrollbars if needed (#7191)
0795410 
The class 'overflow-y-scroll' will always show the scrollbar. Changing
this to 'overflow-y-auto' will only show the scrollbar when needed.

All instances of the 'overflow-y-scroll' class have been changed.

Fixes: #7190
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: only show scrollbars if needed immich-app/immich
1 participant
@uhthomas