Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit people Done button shows wrong count #7341

Closed
1 of 3 tasks
waclaw66 opened this issue Feb 22, 2024 · 6 comments
Closed
1 of 3 tasks

Edit people Done button shows wrong count #7341

waclaw66 opened this issue Feb 22, 2024 · 6 comments

Comments

@waclaw66
Copy link
Contributor

waclaw66 commented Feb 22, 2024

The bug

The toast "Edited XX people" shows wrong count (94) of detected people (46).

obrazek

The OS that Immich Server is running on

Fedora 39

Version of Immich Server

v1.95.1

Version of Immich Mobile App

not relevant

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

not releavant

Your .env content

not releavant

Reproduction steps

1. view asset view people detected
2. click to Edit people
3. click to Done button
4. wrong count of people is shown

Additional information

No response

@waclaw66 waclaw66 changed the title Edit people Done button shows doubled count Edit people Done button shows wrong count Feb 22, 2024
@aviv926
Copy link
Contributor

aviv926 commented Feb 22, 2024

@mertalev Could it be because the rest of the face was not recognized as core?

@mertalev
Copy link
Contributor

It's probably related to counting hidden people. I think this should already be fixed with #7319.

@mertalev
Copy link
Contributor

mertalev commented Feb 22, 2024

Alternatively, if this issue was found on main, it could be caused by that PR.

@waclaw66
Copy link
Contributor Author

It occurs on main as well, checked now. There are no hidden people.

@martabal
Copy link
Member

martabal commented Feb 23, 2024

It's caused by this PR #6751

@aviv926
Copy link
Contributor

aviv926 commented Apr 19, 2024

fixed with #7352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants