chore(server,cli,web): housekeeping and stricter code style #6751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
69e0706
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2765e23e.immich.pages.dev |
| Branch Preview URL: | https://chore-eslint-unicorn-plugin.immich.pages.dev |
…e/eslint-unicorn-plugin
jrasm91
reviewed
Jan 30, 2024
benmccann
reviewed
Jan 30, 2024
…e/eslint-unicorn-plugin
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
…e/eslint-unicorn-plugin
…e/eslint-unicorn-plugin
|
What's the reason for the |
etnoy
changed the title
That's likely an artifact from me running eslint --fix. Thanks for spotting! |
…e/eslint-unicorn-plugin
…e/eslint-unicorn-plugin
benmccann
reviewed
Feb 1, 2024
benmccann
reviewed
Feb 1, 2024
jrasm91
approved these changes
Feb 2, 2024
Thanks for not being too mad about the mess and size of this pr, lol |
jrasm91
added
maintenance
and removed
🗄️server
cli
This was referenced Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspiration came from #6747 (comment)
This turned into a housekeeping and code style PR in general
I've been able to fix a surpring number of bugs with this increased linting!