Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poor HEIC WEB quality #8972

Closed
2 of 3 tasks
maxwase opened this issue Apr 20, 2024 · 8 comments · Fixed by #10478
Closed
2 of 3 tasks

Poor HEIC WEB quality #8972

maxwase opened this issue Apr 20, 2024 · 8 comments · Fixed by #10478
Assignees

Comments

@maxwase
Copy link

maxwase commented Apr 20, 2024

The bug

For some reason image quality for the same photo differs significantly depending on its format. The issue can be seen on mobile with Prefer remote images option selected.

The OS that Immich Server is running on

6.6.19-1-MANJARO

Version of Immich Server

1.102.2

Version of Immich Mobile App

1.101.0 build.131

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

https://github.com/immich-app/immich/blob/e72e41a7aa5374ce763b7b779aed65f2ce761e01/docker/docker-compose.yml

Your .env content

https://github.com/immich-app/immich/blob/e72e41a7aa5374ce763b7b779aed65f2ce761e01/docker/example.env

Reproduction steps

1. Take a photo in HEIC
2. Convert it using `heif-convert photo.HEIC photo.JPG`
3. Upload both photos to Immich
4. See poor HEIC quality compared to JPEG

Relevant log output

No response

Additional information

Web screenshots:
image
image

Option Display original photos does not affect

admin/system-settings?isOpen=image QUALITY=100 setting makes the situation better, however it's still much worse then the converted JPG
image

@mertalev
Copy link
Contributor

Could you share an example image?

@mertalev mertalev self-assigned this Apr 21, 2024
@mertalev
Copy link
Contributor

Also related: #8016.

@maxwase
Copy link
Author

maxwase commented Apr 21, 2024

I would love to, but github does not allow such large files to be attached 😅. I suddenly remembered that I have a dropbox, decided to use it link to the source files
I made a different image to compare: HEIC original, JPG original (adjusted camera settings) and JPG converted from the HEIC original

Tested in Google Chrome:
image
image
image

@yydcool
Copy link

yydcool commented Apr 28, 2024

I also have the same issue.
*.HEIC original image won't load on web client (Chrome v124), the preview image is displayed instead.
I already turned on "Display original photos" knob on web.
Immich Server 1.102.3 (docker)
update: it seems Google Chrome does not support HEIC images, so I think this is expected behavior.

@maxwase
Copy link
Author

maxwase commented Apr 28, 2024

Tested in Firefox:
image
image
image

@mertalev
Copy link
Contributor

I tested and this isn't actually a bug. It's just that HEIC isn't a web-compatible format so we never load the original, whereas we do load the original on zoom for JPG.

@jaisinghdhaliwal
Copy link

Could it be possible to add HEIC support for Safari? Safari 17+ supports HEIC.

@mertalev
Copy link
Contributor

Could it be possible to add HEIC support for Safari? Safari 17+ supports HEIC.

Sure, I made a PR for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants