feat(web): send test email button #10011
Conversation
| @HttpCode(HttpStatus.NO_CONTENT) | ||
| @Authenticated() | ||
| testEmailNotification(@Auth() auth: AuthDto) { | ||
| return this.service.handleTestEmailSetup({ id: auth.user.id }); |
There was a problem hiding this comment.
Feedback from the web notification is pretty bad. It tells you a test email has been sent, even though the smtp config is empty.
Why isn't NotificationRepository.sendEmail called directly? Then any errors can be relayed to the user.
There was a problem hiding this comment.
I am reworking to invoke those repository method directly
There was a problem hiding this comment.
That's much better already. However, I still think there's room for improvement. When an smtp error like 530 5.7.0 User not authenticated occurs, it would be beneficial to show this error to troubleshoot the settings.
There was a problem hiding this comment.
This will be a larger rework on how we send the HTTPException and have it displayed correctly with the openapi runtime we use
web/src/lib/components/admin-page/settings/notification-settings/notification-settings.svelte
Outdated
Show resolved
Hide resolved
web/src/lib/components/admin-page/settings/notification-settings/notification-settings.svelte
Outdated
Show resolved
Hide resolved
web/src/lib/components/admin-page/settings/notification-settings/notification-settings.svelte
Outdated
Show resolved
Hide resolved
This PR adds a button to send a test email when setting up STMP configuration, then save the setting if an email is sent succesfully.