Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): proper asset sync #10019

Merged
merged 7 commits into from
Jun 9, 2024
Merged

fix(server): proper asset sync #10019

merged 7 commits into from
Jun 9, 2024

Conversation

fyfrey
Copy link
Contributor

@fyfrey fyfrey commented Jun 7, 2024

fixes #9534 and bunch of other issues

breaking change! app and server must be on same version to work

with this change:

  1. the server full sync method always returns the exact number of requested assets (unless it is the last chunk)
  2. sync methods load the stacked asset count in a follow-up query via loadRelationCountAndMap so that limit works correctly
  3. the app stops the fetching for more assets when the first non-full chunk is received
  4. syncing uses id instead of fileCreatedAt because it may have weird metadata issues.

@alextran1502
Copy link
Contributor

Cloning my prod instance tonight to test this in the morning! For science!!!

Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Server code looks good to me!

@alextran1502 alextran1502 changed the title fix(server,mobile)!: proper asset sync fix(server)!: proper asset sync Jun 7, 2024
@alextran1502 alextran1502 changed the title fix(server)!: proper asset sync fix(server): proper asset sync Jun 7, 2024
@alextran1502 alextran1502 merged commit 972c66d into main Jun 9, 2024
24 checks passed
@alextran1502 alextran1502 deleted the dev/proper-asset-sync-1 branch June 9, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Since apk v1.105.0 login/upload possible but timeline won't refresh, keeps spinning
4 participants