fix(server): add fallback for video thumbnail generation #10034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mertalev
force-pushed
the
fix/server-video-thumbnail-fallback
branch
from
7292981
to
0ae5343
Compare
mertalev
force-pushed
the
fix/server-video-thumbnail-fallback
branch
from
0ae5343
to
beda772
Compare
alextran1502
approved these changes
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR lets FFmpeg fall back to the first frame if it can't find a better one. Also sets the format back to yuv420p since I noticed that converting to any other format lowers contrast quite a bit. Lastly, sets the fps to round up because it can otherwise drop the first and only keyframe in a video.
How Has This Been Tested?
Tested by running thumbnail generation on a few hundred videos, some of which failed with the command on main, and confirming that they were generated successfully.