Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: automatically apply PR labels #10064

Merged

Conversation

roschaefer
Copy link
Contributor

@roschaefer roschaefer commented Jun 9, 2024

Motivation

For me as a new contributor it is frustrating to submit a PR and it will always fail. Even worse: I have to wait for another contributor with more power to assign the label for me.

This will improve developer experience, as some of the labels can be assigned automatically based on changed files.

How to test

  1. Merge this PR
  2. Submit a couple of PRs with changes in the respective directories
  3. Labels should be automatically applied
  4. "Enforce PR labels" github workflow will re-run when "Pull Request Labeler" completes

You can check out my fork: roschaefer#4

image

Motivation
----------
For me as a new contributor it is frustrating to submit a PR and it will always fail. Even worse: I have to wait for another contributor with more power to assign the label for me.

This will improve developer experience, as some of the labels can be assigned automatically based on changed files.

How to test
-----------
1. Merge this PR
2. Submit a couple of PRs with changes in the respective directories
3. Labels should be automatically applied
4. "Enforce PR labels" github workflow will re-run when "Pull Request Labeler" completes
@roschaefer roschaefer requested a review from bo0tzz as a code owner June 9, 2024 19:07
@@ -0,0 +1,23 @@
cli:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some labels have emojis, some don't?

Release notes use a different spelling, too: https://github.com/immich-app/immich/releases

@bo0tzz bo0tzz added the github_actions Pull requests that update GitHub Actions code label Jun 9, 2024
Copy link
Member

@bo0tzz bo0tzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd been meaning to do this, thanks!

@alextran1502 alextran1502 merged commit 9c33722 into immich-app:main Jun 9, 2024
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants