chore: remove pr labeler requirement #10081
Conversation
|
You will get no green checkmark automatically though |
The two don't work together, the label gets applied too late and then the label check job doesn't run because it won't be triggered by the bot adding a label. |
|
Ah, because the workflow_run won't be triggered due to that annoying loop prevention, ugh... Any ideas for how we can work around that? If we can I think it would still be worth having this enforcement. As an alternative, maybe the enforcement can be baked into the other job? |
We talked about it earlier and really it's not a big deal if it doesn't get applied, we can always sort any missing a label when we come to making the release notes |
Definitely true, but IMO it's much easier to do that when the context of the PR is still fresh. |
jrasm91
dismissed
bo0tzz’s stale review
Going to test without it and see how it goes
| workflow_run: | ||
| workflows: ["Pull Request Labeler"] | ||
| types: | ||
| - completed |
There was a problem hiding this comment.
This very condition was supposed to re-run the "Enforce PR labels" after "Pull Request Labeler". At least, that's how it worked in my fork.
So what's different? In the PR discussion a loop prevention is mentioned. Does that prevent the desired behaviour?
There was a problem hiding this comment.
Not sure really, I think we basically decided it wasn't worth investigating when the labels aren't actually "mandatory" they're just a really nice help and the other action should catch most cases anyway
There was a problem hiding this comment.
Fair enough. When I implemented it this way, I felt a little dirty about the dependency across workflows. Less complexity is a good thing, too.
Remove pr label enforcing job since it is now done through CI