Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): missing svelte translations #10199

Merged
merged 16 commits into from
Jun 12, 2024

Conversation

waclaw66
Copy link
Contributor

Adds missing svelte translations.
Section page titles (e.g. Photos, Explore, Map) within .ts files are still untranslated.

@danieldietzler
Copy link
Member

I think this is a duplicate of #10161 in many aspects, correct?

@waclaw66
Copy link
Contributor Author

waclaw66 commented Jun 12, 2024

Unfortunatelly I haven't noticed that PR before :( I can wait untit #10161 is merged and then rebase my branch a add the rest of missing translations. Or @michelheusschen can add those to his branch.

@waclaw66 waclaw66 marked this pull request as draft June 12, 2024 09:43
@michelheusschen
Copy link
Contributor

I should have added translations for everything user settings and admin related. If you exclude those from your PR there won't be any conflicts and you can proceed translating other areas.

@danieldietzler
Copy link
Member

@waclaw66 the PR just got merged, so you can rebase now :)

@zackpollard
Copy link
Contributor

zackpollard commented Jun 12, 2024

@waclaw66 We can potentially pull this into the upcoming hotfix if you get it rebased in the next couple of hours, if not no worries, ty for the PR 😄

@waclaw66
Copy link
Contributor Author

@waclaw66 We can potentially pull this into the upcoming hotfix if you get it rebased in the next couple of hours, if not no worries, ty for the PR 😄

I would like to get it done soon, unfortunatelly I got stucked on that failing test. Could you please to help me find out what is the problem? Thanks.

@michelheusschen
Copy link
Contributor

michelheusschen commented Jun 12, 2024

The merge key was removed. I didn't notice it should get used, so you have to add it back

web/src/lib/i18n/en.json Outdated Show resolved Hide resolved
web/src/lib/i18n/en.json Outdated Show resolved Hide resolved
waclaw66 and others added 8 commits June 12, 2024 14:42
…tion-albums.svelte

Co-authored-by: Michel Heusschen <59014050+michelheusschen@users.noreply.github.com>
Co-authored-by: Michel Heusschen <59014050+michelheusschen@users.noreply.github.com>
@waclaw66 waclaw66 marked this pull request as ready for review June 12, 2024 13:00
@waclaw66
Copy link
Contributor Author

It should be done, ready to merge.

@zackpollard zackpollard merged commit 376fead into immich-app:main Jun 12, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants