fix(web): more language selector nits #10271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bo0tzz
approved these changes
Jun 13, 2024
| @@ -60,6 +60,7 @@ | |||
| const activate = () => { | |||
| isActive = true; | |||
| input?.select(); | |||
| searchQuery = ''; | |||
There was a problem hiding this comment.
Why clear the value?
There was a problem hiding this comment.
In order to get the dropdown to show the full list. When removing focus, the deactivate() fn below restores the query.
There was a problem hiding this comment.
Ideally the search query remains in the input field while also showing all options, but there doesn't seem to be an easy way to do this. input?.select(); can be removed though as it no longer serves a purpose
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.