Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(server): event emits #10648

Merged
merged 2 commits into from
Jun 27, 2024
Merged

refactor(server): event emits #10648

merged 2 commits into from
Jun 27, 2024

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented Jun 27, 2024

  • Consolidate the interface for emitting events between services.
  • Use event handlers to move logic to appropriate services (decoupling the event source and responses)
  • Refactor events: onBootstrap, onShutdown, onConfigUpdate, and onConfigValidate
  • In the future, looking to add additional events, like onAssetDelete (before/after)

TODO:

  • test cross process events still work correctly (config update, concurrency changes)
  • validate start up logic still works correctly and everything is initialized properly

@jrasm91 jrasm91 requested a review from zackpollard June 27, 2024 04:49
@jrasm91 jrasm91 force-pushed the refactor/event-emits branch 3 times, most recently from c59ffd2 to 6a0402b Compare June 27, 2024 06:03
Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

server/src/decorators.ts Outdated Show resolved Hide resolved
@jrasm91 jrasm91 merged commit 72bf943 into main Jun 27, 2024
25 checks passed
@jrasm91 jrasm91 deleted the refactor/event-emits branch June 27, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants