Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): wrong video rotation with QSV and RKMPP decoding #10905

Merged
merged 5 commits into from
Jul 9, 2024

Conversation

apeman76
Copy link
Contributor

@apeman76 apeman76 commented Jul 5, 2024

This should fix #10634 , #10498 and #9252. Could possibly also fix photos having the same issue if hardware recoding? i.e. #8355
nvenc already had the option, but QSV and RKMPP was missing it

Example: Input has a raster size of 1920x1080 with 90° clockwise rotate side data. 
Running ffmpeg -i input.mp4 output.mp4 will result in the video being rotated 90° clockwise according to the rotate side data. 
The output will be 1080x1920 with the rotate side data removed.

from https://stackoverflow.com/a/69396105

Fixes #10634
Fixes #10498
Fixes #9252

@apeman76 apeman76 changed the title Add noautorotate to all HW recorders Add noautorotate to all HW recoders Jul 5, 2024
@mertalev
Copy link
Contributor

mertalev commented Jul 5, 2024

Thanks for the PR! You'll want to update the tests as well to include this flag.

@apeman76
Copy link
Contributor Author

apeman76 commented Jul 5, 2024

Thanks for the PR! You'll want to update the tests as well to include this flag.

Should be added now, let me know if it's correct :)

@mertalev mertalev changed the title Add noautorotate to all HW recoders fix(server): wrong video rotation with QSV and RKMPP decoding Jul 6, 2024
@mertalev
Copy link
Contributor

mertalev commented Jul 6, 2024

Running npm run format:fix should take care of that failed check.

Copy link
Contributor

@mertalev mertalev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@alextran1502
Copy link
Contributor

@apeman76 Can you help fix the test by running npm run format:fix? Somehow I cannot push the fix to your branch

@apeman76
Copy link
Contributor Author

apeman76 commented Jul 9, 2024

@apeman76 Can you help fix the test by running npm run format:fix? Somehow I cannot push the fix to your branch

Done :)

@mertalev mertalev enabled auto-merge (squash) July 9, 2024 15:13
@mertalev mertalev merged commit 678111e into immich-app:main Jul 9, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recoded video - rotation wrong Video rotation wrong when played back.
3 participants