feat(web): improve show & hide people accessibility #10954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
michelheusschen
commented
Jul 8, 2024
michelheusschen
commented
- Use focus trap
- Add label for each toggle visibility state
- Mark as modal dialog
- Make toggling individual people accessible
michelheusschen
force-pushed
the
feat/web-improve-show-hide-people-a11y
branch
from
467b4e0
to
33007d9
Compare
jrasm91
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
This is better than what we have now. I was wondering what you think about just having a dedicated secondary menu instead though. Similar to the "add to album" action, we could just have it open with these options:
- Show all
- Hide all
- Hide unnamed
I think it would be more usable/intuitive. Clicking through a list of options is a bit more confusing imo.
|
I agree with Jason that having a context menu with explicit text will help with UX |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.