Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reset admin password #1335

Merged
merged 2 commits into from
Jan 16, 2023
Merged

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented Jan 16, 2023

The PR moves the business logic for the command into the UserService and also prints the admin email address.

reset-admin-password

@vercel
Copy link

vercel bot commented Jan 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
immich ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 16, 2023 at 6:11PM (UTC)
immich-code-coverage ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 16, 2023 at 6:11PM (UTC)

@vercel vercel bot temporarily deployed to Preview – immich January 16, 2023 15:45 Inactive
@vercel vercel bot temporarily deployed to Preview – immich-code-coverage January 16, 2023 15:46 Inactive
if (provided) {
console.log(`The admin password has been updated.`);
} else {
console.log(`The admin password has been updated to:\n${password}`);

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information

This logs sensitive data returned by [an access to password](1) as clear text. This logs sensitive data returned by [an access to providedPassword](2) as clear text. This logs sensitive data returned by [an access to password](3) as clear text.
@jrasm91 jrasm91 force-pushed the refactor/reset-admin-password branch from f6a3512 to 9402df0 Compare January 16, 2023 18:08
@alextran1502 alextran1502 merged commit 1e2f026 into main Jan 16, 2023
@alextran1502 alextran1502 deleted the refactor/reset-admin-password branch January 16, 2023 18:09
@vercel vercel bot temporarily deployed to Preview – immich-code-coverage January 16, 2023 18:09 Inactive
@vercel vercel bot temporarily deployed to Preview – immich January 16, 2023 18:11 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants